Skip to content

added features and deprecated interact #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2024
Merged

added features and deprecated interact #5313

merged 4 commits into from
Nov 6, 2024

Conversation

@saminacodes
Copy link
Member

@saminacodes saminacodes commented Nov 5, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on updating the apps/portal project by removing the interact section, adding new SVG icons, and enhancing the page.mdx files with improved feature cards for deployment and exploration functionalities.

Detailed summary

  • Deleted apps/portal/src/app/contracts/interact/overview/page.mdx.
  • Removed interactSlug and related sidebar entry in sidebar.tsx.
  • Added multiple SVG icons in public/icons/feature-cards.
  • Updated feature sections in page.mdx files for deployment and exploration, replacing text with FeatureCard components.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 83af97c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 0:05am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 0:05am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Nov 6, 2024 0:05am
wallet-ui ⬜️ Skipped (Inspect) Nov 6, 2024 0:05am

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Nov 5, 2024
@codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.59%. Comparing base (880c345) to head (83af97c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5313   +/-   ##
=======================================
  Coverage   45.59%   45.59%           
=======================================
  Files        1069     1069           
  Lines       55584    55584           
  Branches     4045     4045           
=======================================
  Hits        25342    25342           
  Misses      29552    29552           
  Partials      690      690
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 85e12e4
packages 40.70% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 3 s (-22.8% 🔽) 3.9 s
thirdweb (cjs) 103 KB (0%) 2.1 s (0%) 5.6 s (-10.06% 🔽) 7.7 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 259 ms (+52.99% 🔺) 356 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 91 ms (-40.92% 🔽) 101 ms
thirdweb/react (minimal + tree-shaking) 17.51 KB (0%) 351 ms (0%) 828 ms (+171.6% 🔺) 1.2 s

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 5, 2024 23:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 5, 2024 23:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 5, 2024 23:59 Inactive
@jnsdls jnsdls merged commit d7f161b into main Nov 6, 2024
30 of 31 checks passed
@jnsdls jnsdls deleted the contracts-overviews branch November 6, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

@MananTank MananTank Awaiting requested review from MananTank

Assignees

No one assigned

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saminacodes @jnsdls